Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard handling is slightly broken #742

Open
benlaurie opened this issue Feb 15, 2020 · 3 comments
Open

Keyboard handling is slightly broken #742

benlaurie opened this issue Feb 15, 2020 · 3 comments

Comments

@benlaurie
Copy link

@benlaurie benlaurie commented Feb 15, 2020

If I rattle on the keyboard I get ControlLeft coming up regularly, even though I am far from the control keys. Upgrading pc_keyboard to 0.5.0 seems to fix it.

@phil-opp

This comment has been minimized.

Copy link
Owner

@phil-opp phil-opp commented Feb 18, 2020

Thanks for reporting! Maybe thejpster/pc-keyboard@1b11ccc fixed this?

Updating the blog to pc_keyboard 0.5.0 seems like a good idea anyway. I would be happy to merge a pull request against the post-07 branch if someone wants to do the update.

@RKennedy9064

This comment has been minimized.

Copy link

@RKennedy9064 RKennedy9064 commented Feb 23, 2020

@phil-opp I added a PR to update the pc-keyboard crate. Let me know what you think when you get a chance.

@benlaurie

This comment has been minimized.

Copy link
Author

@benlaurie benlaurie commented Feb 23, 2020

PR is #756 - thanks @RKennedy9064!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.